[Intel-gfx] [PATCH v2] drm/i915: Sort EHL/JSL PCI IDs

[Ville Syrjälä]

On Fri, Oct 30, 2020 at 07:34:01PM +0000, Srivatsa, Anusha wrote:
> 
> 
> > -----Original Message-----
> > From: Ville Syrjala <ville.syrjala at linux.intel.com>
> > Sent: Friday, October 30, 2020 9:41 AM
> > To: intel-gfx at lists.freedesktop.org
> > Cc: Srivatsa, Anusha <anusha.srivatsa at intel.com>
> > Subject: [PATCH v2] drm/i915: Sort EHL/JSL PCI IDs
> > 
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Sort the EHL/JSL PCI IDs numerically. Some order seems better than
> > randomness.
> > 
> > v2: Deal with the JSL vs. EHL split
> > 
> > Reviewed-by: Anusha Srivatsa <anusha.srivatsa at intel.com> #v1
> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > ---
> >  include/drm/i915_pciids.h | 14 +++++++-------
> >  1 file changed, 7 insertions(+), 7 deletions(-)
> > 
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index
> > 3b5ed1e4f3ec..4a0a06f4a81e 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -585,19 +585,19 @@
> >  /* EHL */
> >  #define INTEL_EHL_IDS(info) \
> >  	INTEL_VGA_DEVICE(0x4500, info),	\
> 0x4500 is actually no longer  a valid PCI ID for the platform.

Can you fire off a patch to remove the invalid stuff?
I can hold off on pushing this until those changes are
done, if that's the more convenient approach.

> 
> Anusha
> > -	INTEL_VGA_DEVICE(0x4571, info), \
> > -	INTEL_VGA_DEVICE(0x4551, info), \
> >  	INTEL_VGA_DEVICE(0x4541, info), \
> > +	INTEL_VGA_DEVICE(0x4551, info), \
> > +	INTEL_VGA_DEVICE(0x4555, info), \
> >  	INTEL_VGA_DEVICE(0x4557, info), \
> > -	INTEL_VGA_DEVICE(0x4555, info)
> > +	INTEL_VGA_DEVICE(0x4571, info)
> > 
> >  /* JSL */
> >  #define INTEL_JSL_IDS(info) \
> > -	INTEL_VGA_DEVICE(0x4E71, info), \
> > -	INTEL_VGA_DEVICE(0x4E61, info), \
> > -	INTEL_VGA_DEVICE(0x4E57, info), \
> > +	INTEL_VGA_DEVICE(0x4E51, info), \
> >  	INTEL_VGA_DEVICE(0x4E55, info), \
> > -	INTEL_VGA_DEVICE(0x4E51, info)
> > +	INTEL_VGA_DEVICE(0x4E57, info), \
> > +	INTEL_VGA_DEVICE(0x4E61, info), \
> > +	INTEL_VGA_DEVICE(0x4E71, info)
> > 
> >  /* TGL */
> >  #define INTEL_TGL_12_GT1_IDS(info) \
> > --
> > 2.26.2
> 

-- 
Ville Syrjälä
Intel