[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

Patchwork patchwork at emeril.freedesktop.org
Thu Sep 3 11:34:26 UTC 2020


== Series Details ==

Series: acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
URL   : https://patchwork.freedesktop.org/series/81284/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1697ae1e044d ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase
3d61460209ae ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation)
3323c5fd40fd pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()
a5e5abaeb383 pwm: lpss: Add range limit check for the base_unit register value
35844baeea43 pwm: lpss: Add pwm_lpss_prepare_enable() helper
-:46: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#46: FILE: drivers/pwm/pwm-lpss.c:137:
+	pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == false);

-:51: CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#51: FILE: drivers/pwm/pwm-lpss.c:142:
+	pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == true);

total: 0 errors, 0 warnings, 2 checks, 67 lines checked
6d4f51125b5e pwm: lpss: Make pwm_lpss_apply() not rely on existing hardware state
-:93: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#93: FILE: drivers/pwm/pwm-lpss.c:134:
+	pwm_lpss_cond_enable(pwm, lpwm->info->bypass == false);

-:99: CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#99: FILE: drivers/pwm/pwm-lpss.c:139:
+	pwm_lpss_cond_enable(pwm, lpwm->info->bypass == true);

total: 0 errors, 0 warnings, 2 checks, 63 lines checked
f1828c9c0d08 pwm: lpss: Remove suspend/resume handlers
1bcad686586e pwm: crc: Fix period / duty_cycle times being off by a factor of 256
f35514f16ee3 pwm: crc: Fix off-by-one error in the clock-divider calculations
fba1b41f563c pwm: crc: Fix period changes not having any effect
17dac256640e pwm: crc: Enable/disable PWM output on enable/disable
c2ba8c2eec46 pwm: crc: Implement apply() method to support the new atomic PWM API
edc4cede8f26 pwm: crc: Implement get_state() method
4ab3de063861 drm/i915: panel: Add get_vbt_pwm_freq() helper
cb09d0ae8c40 drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller
5751ab4b4c97 drm/i915: panel: Honor the VBT PWM min setting for devs with an external PWM controller
71e10e2a06cb drm/i915: panel: Use atomic PWM API for devs with an external PWM controller




More information about the Intel-gfx mailing list