[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API

Patchwork patchwork at emeril.freedesktop.org
Thu Sep 3 11:54:07 UTC 2020


== Series Details ==

Series: acpi/pwm/i915: Convert pwm-crc and i915 driver's PWM code to use the atomic PWM API
URL   : https://patchwork.freedesktop.org/series/81287/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
1168abd5ce8d ACPI / LPSS: Resume Cherry Trail PWM controller in no-irq phase
49747f4e3a9e ACPI / LPSS: Save Cherry Trail PWM ctx registers only once (at activation)
97b4a9aebcb4 pwm: lpss: Fix off by one error in base_unit math in pwm_lpss_prepare()
2e7faec371d2 pwm: lpss: Add range limit check for the base_unit register value
94a41c16c5ba pwm: lpss: Add pwm_lpss_prepare_enable() helper
-:46: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#46: FILE: drivers/pwm/pwm-lpss.c:137:
+	pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == false);

-:51: CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#51: FILE: drivers/pwm/pwm-lpss.c:142:
+	pwm_lpss_cond_enable(pwm, enable && lpwm->info->bypass == true);

total: 0 errors, 0 warnings, 2 checks, 67 lines checked
b6ce0150e736 pwm: lpss: Make pwm_lpss_apply() not rely on existing hardware state
-:93: CHECK:BOOL_COMPARISON: Using comparison to false is error prone
#93: FILE: drivers/pwm/pwm-lpss.c:134:
+	pwm_lpss_cond_enable(pwm, lpwm->info->bypass == false);

-:99: CHECK:BOOL_COMPARISON: Using comparison to true is error prone
#99: FILE: drivers/pwm/pwm-lpss.c:139:
+	pwm_lpss_cond_enable(pwm, lpwm->info->bypass == true);

total: 0 errors, 0 warnings, 2 checks, 63 lines checked
48f37ff234b3 pwm: lpss: Remove suspend/resume handlers
247ad837e2cd pwm: crc: Fix period / duty_cycle times being off by a factor of 256
0b9d965a728a pwm: crc: Fix off-by-one error in the clock-divider calculations
666a424bb1a8 pwm: crc: Fix period changes not having any effect
f29b5d035a49 pwm: crc: Enable/disable PWM output on enable/disable
88ea19297024 pwm: crc: Implement apply() method to support the new atomic PWM API
ad30d11970a4 pwm: crc: Implement get_state() method
240678c00b3d drm/i915: panel: Add get_vbt_pwm_freq() helper
d1aacec4e432 drm/i915: panel: Honor the VBT PWM frequency for devs with an external PWM controller
7e1d6106ba3a drm/i915: panel: Honor the VBT PWM min setting for devs with an external PWM controller
5f2ad76ad27d drm/i915: panel: Use atomic PWM API for devs with an external PWM controller




More information about the Intel-gfx mailing list