[Intel-gfx] [PATCH] drm/i915/gvt: Fix NULL pointer dereference in intel_vgpu_reg_rw_edid()
Markus Elfring
Markus.Elfring at web.de
Tue Sep 8 15:47:34 UTC 2020
> In the function intel_vgpu_reg_rw_edid of gvt/kvmgt.c, pos can get equal to NULL for GPUs that do not
> properly support EDID. …
* I propose to reconsider the previous patch subject once more.
* Did the script “checkpatch.pl” point any adjustment possibilities out
for the change description?
> This patch solves this problem by …
Would an imperative wording be preferred for the commit message?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst#n151
> … to a nagative value, …
Please avoid a typo here.
I suggest to add the tag “Fixes” to the commit message.
Regards,
Markus
More information about the Intel-gfx
mailing list