[Intel-gfx] [12/12] drm/i915: Nuke pointless variable

Souza, Jose jose.souza at intel.com
Tue Sep 8 17:00:57 UTC 2020


On Wed, 2020-07-01 at 00:56 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <
> ville.syrjala at linux.intel.com
> >
> 
> No point in assigning the function return value to a local
> variable if we're just going to use it the one time.
> 

Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

> Signed-off-by: Ville Syrjälä <
> ville.syrjala at linux.intel.com
> >
> ---
>  drivers/gpu/drm/i915/display/intel_hotplug.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_hotplug.c b/drivers/gpu/drm/i915/display/intel_hotplug.c
> index 8a8e77314a4e..938466b2c9d1 100644
> --- a/drivers/gpu/drm/i915/display/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/display/intel_hotplug.c
> @@ -480,7 +480,6 @@ void intel_hpd_irq_handler(struct drm_i915_private *dev_priv,
>  	 * only the one of them (DP) will have ->hpd_pulse().
>  	 */
>  	for_each_intel_encoder(&dev_priv->drm, encoder) {
> -		bool has_hpd_pulse = intel_encoder_has_hpd_pulse(encoder);
>  		enum port port = encoder->port;
>  		bool long_hpd;
>  
> @@ -488,7 +487,7 @@ void intel_hpd_irq_handler(struct drm_i915_private *dev_priv,
>  		if (!(BIT(pin) & pin_mask))
>  			continue;
>  
> -		if (!has_hpd_pulse)
> +		if (!intel_encoder_has_hpd_pulse(encoder))
>  			continue;
>  
>  		long_hpd = long_mask & BIT(pin);
> 


More information about the Intel-gfx mailing list