[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/4] drm/i915/gt: Widen CSB pointer to u64 for the parsers

Patchwork patchwork at emeril.freedesktop.org
Tue Sep 15 15:23:26 UTC 2020


== Series Details ==

Series: series starting with [CI,1/4] drm/i915/gt: Widen CSB pointer to u64 for the parsers
URL   : https://patchwork.freedesktop.org/series/81688/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0479f6ad75dc drm/i915/gt: Widen CSB pointer to u64 for the parsers
f495c988d0c6 drm/i915/gt: Wait for CSB entries on Tigerlake
-:24: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d8f505311717 ("drm/i915/icl: Forcibly evict stale csb entries")'
#24: 
References: d8f505311717 ("drm/i915/icl: Forcibly evict stale csb entries")

-:52: ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#52: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:2509:
+		if (wait_for_atomic_us((entry = READ_ONCE(*csb)) != -1, 50))

total: 2 errors, 0 warnings, 0 checks, 33 lines checked
53ad42fb5853 drm/i915/gt: Apply the CSB w/a for all
-:12: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit d8f505311717 ("drm/i915/icl: Forcibly evict stale csb entries")'
#12: 
References: d8f505311717 ("drm/i915/icl: Forcibly evict stale csb entries")

-:82: ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#82: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:2536:
+	if (wait_for_atomic_us((entry = READ_ONCE(*csb)) != -1, 50))

total: 2 errors, 0 warnings, 0 checks, 123 lines checked
f9b252d2da73 drm/i915/gt: Use a mmio read of the CSB in case of failure
-:42: ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#42: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:2546:
+	if (wait_for_atomic_us((entry = READ_ONCE(*csb)) != -1, 10)) {

total: 1 errors, 0 warnings, 0 checks, 69 lines checked




More information about the Intel-gfx mailing list