[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls

Patchwork patchwork at emeril.freedesktop.org
Tue Sep 15 17:37:08 UTC 2020


== Series Details ==

Series: drm/i915: Add support for Intel's eDP backlight controls
URL   : https://patchwork.freedesktop.org/series/81702/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
d4faeb36f092 drm/i915/dp: Program source OUI on eDP panels
0debab180b3b drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*
740d9664b33f drm/i915: Keep track of pwm-related backlight hooks separately
1363d7a69e3a drm/i915: Enable Intel's HDR backlight interface (only SDR for now)
-:210: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#210: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:147:
+			return panel->backlight.max;
+		} else {

-:231: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t'
#231: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:168:
+	uint8_t buf[4] = { 0 };

-:250: WARNING:LINE_SPACING: Missing a blank line after declarations
#250: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:187:
+		const u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+		intel_panel_set_pwm_level(conn_state, pwm_level);

total: 0 errors, 2 warnings, 1 checks, 573 lines checked
e7a29d101ca4 drm/dp: Revert "drm/dp: Introduce EDID-based quirks"
-:205: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#205: FILE: drivers/gpu/drm/i915/display/intel_dp.c:7467:
+			drm_connector_update_edid_property(connector,
+								edid);

total: 0 errors, 0 warnings, 1 checks, 220 lines checked




More information about the Intel-gfx mailing list