[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev2)

Patchwork patchwork at emeril.freedesktop.org
Wed Sep 16 19:05:33 UTC 2020


== Series Details ==

Series: drm/i915: Add support for Intel's eDP backlight controls (rev2)
URL   : https://patchwork.freedesktop.org/series/81702/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8aaf96a8cf98 drm/i915/dp: Program source OUI on eDP panels
ba0a5a5d9619 drm/i915: Rename pwm_* backlight callbacks to ext_pwm_*
52b7a7565310 drm/i915: Keep track of pwm-related backlight hooks separately
ed15e7f4a32d drm/i915/dp: Rename eDP VESA backlight interface functions
ecaa8bceac61 drm/i915/dp: Add register definitions for Intel HDR backlight interface
98099af6f150 drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
-:151: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#151: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:147:
+			return panel->backlight.max;
+		} else {

-:172: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u8' over 'uint8_t'
#172: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:168:
+	uint8_t buf[4] = { 0 };

-:191: WARNING:LINE_SPACING: Missing a blank line after declarations
#191: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:187:
+		const u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+		intel_panel_set_pwm_level(conn_state, pwm_level);

total: 0 errors, 2 warnings, 1 checks, 382 lines checked
f0c139b58661 drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight
6d35240b4140 drm/dp: Revert "drm/dp: Introduce EDID-based quirks"




More information about the Intel-gfx mailing list