[Intel-gfx] [PATCH] drm/i915/uc: tune down GuC communication enabled/disabled messages

Jani Nikula jani.nikula at intel.com
Wed Sep 23 09:09:37 UTC 2020


On Thu, 17 Sep 2020, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> On Thu, Sep 17, 2020 at 07:50:56PM +0300, Jani Nikula wrote:
>> The GuC communication enabled/disabled messages are too noisy in info
>> level. Convert them from info to debug level, and switch to device based
>> logging while at it.
>> 
>> Reported-by: Karol Herbst <kherbst at redhat.com>
>> Cc: Karol Herbst <kherbst at redhat.com>
>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Thanks, pushed to drm-intel-gt-next.

BR,
Jani.


>
>> ---
>>  drivers/gpu/drm/i915/gt/uc/intel_uc.c | 6 ++++--
>>  1 file changed, 4 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc.c b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>> index d6f55f70889d..4e6070e95fe9 100644
>> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc.c
>> @@ -231,13 +231,15 @@ static int guc_enable_communication(struct intel_guc *guc)
>>  	intel_guc_ct_event_handler(&guc->ct);
>>  	spin_unlock_irq(&i915->irq_lock);
>>  
>> -	DRM_INFO("GuC communication enabled\n");
>> +	drm_dbg(&i915->drm, "GuC communication enabled\n");
>>  
>>  	return 0;
>>  }
>>  
>>  static void guc_disable_communication(struct intel_guc *guc)
>>  {
>> +	struct drm_i915_private *i915 = guc_to_gt(guc)->i915;
>> +
>>  	/*
>>  	 * Events generated during or after CT disable are logged by guc in
>>  	 * via mmio. Make sure the register is clear before disabling CT since
>> @@ -257,7 +259,7 @@ static void guc_disable_communication(struct intel_guc *guc)
>>  	 */
>>  	guc_get_mmio_msg(guc);
>>  
>> -	DRM_INFO("GuC communication disabled\n");
>> +	drm_dbg(&i915->drm, "GuC communication disabled\n");
>>  }
>>  
>>  static void __uc_fetch_firmwares(struct intel_uc *uc)
>> -- 
>> 2.20.1
>> 
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list