[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/jsl: Update JasperLake Voltage swing table

Patchwork patchwork at emeril.freedesktop.org
Mon Sep 28 08:51:42 UTC 2020


== Series Details ==

Series: drm/i915/jsl: Update JasperLake Voltage swing table
URL   : https://patchwork.freedesktop.org/series/82150/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
7785c9b4e203 drm/i915/jsl: Split EHL/JSL platform info and PCI ids
-:20: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'dev_priv' - possible side-effects?
#20: FILE: drivers/gpu/drm/i915/i915_drv.h:1420:
+#define IS_ELKHARTLAKE(dev_priv) (IS_PLATFORM(dev_priv, INTEL_ELKHARTLAKE) || \
+				IS_PLATFORM(dev_priv, INTEL_JASPERLAKE))

-:98: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#98: FILE: include/drm/i915_pciids.h:592:
+#define INTEL_JSL_IDS(info) \
+	INTEL_VGA_DEVICE(0x4E71, info), \
 	INTEL_VGA_DEVICE(0x4E61, info), \
 	INTEL_VGA_DEVICE(0x4E57, info), \
 	INTEL_VGA_DEVICE(0x4E55, info), \

-:98: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#98: FILE: include/drm/i915_pciids.h:592:
+#define INTEL_JSL_IDS(info) \
+	INTEL_VGA_DEVICE(0x4E71, info), \
 	INTEL_VGA_DEVICE(0x4E61, info), \
 	INTEL_VGA_DEVICE(0x4E57, info), \
 	INTEL_VGA_DEVICE(0x4E55, info), \

total: 1 errors, 0 warnings, 2 checks, 66 lines checked
07ca5d2ec781 drm/i915/edp/jsl: Update vswing table for HBR and HBR2
-:77: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#77: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1143:
+				return jsl_combo_phy_ddi_translations_edp_hbr2;
+			} else {

-:82: WARNING:PREFER_FALLTHROUGH: Prefer 'fallthrough;' over fallthrough comment
#82: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1148:
+		/* fall through */

-:100: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#100: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:2325:
+			jsl_get_combo_buf_trans(encoder, encoder->type,
+					intel_dp->link_rate, &n_entries);

total: 0 errors, 2 warnings, 1 checks, 98 lines checked




More information about the Intel-gfx mailing list