[Intel-gfx] [PATCH V2] drm/i915/display: Disable PSR2 on Gen12/12+

[Shankar, Uma]

> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Tejas
> Upadhyay
> Sent: Monday, March 22, 2021 4:37 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: Pandey, Hariom <hariom.pandey at intel.com>
> Subject: [Intel-gfx] [PATCH V2] drm/i915/display: Disable PSR2 on Gen12/12+
> 
> In light of PSR2 can be enabled only on BOM9 platform team has requested to
> disable PSR2 by default in driver, starting with gfx-driver-ci-master-7517. Disabling it
> for all gen12/12+.
> 
> Changes since V1 :
> 	- Added check for GEN12/12+
> 	- Modified commit message accoringly
> 

Nack on this change.

This is not right, please abandon and drop this change.

> Signed-off-by: Tejas Upadhyay <tejaskumarx.surendrakumar.upadhyay at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c
> b/drivers/gpu/drm/i915/display/intel_psr.c
> index cd434285e3b7..df55799c53da 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -727,7 +727,7 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
>  		return false;
> 
>  	/* JSL and EHL only supports eDP 1.3 */
> -	if (IS_JSL_EHL(dev_priv)) {
> +	if (IS_JSL_EHL(dev_priv) || INTEL_GEN(dev_priv) >= 12) {
>  		drm_dbg_kms(&dev_priv->drm, "PSR2 not supported by phy\n");
>  		return false;
>  	}
> --
> 2.30.0
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx