[Intel-gfx] [PATCH 18/19] drm/i915/gtt: map the PD up front

Jani Nikula jani.nikula at linux.intel.com
Mon Apr 12 16:01:19 UTC 2021


On Mon, 12 Apr 2021, Daniel Vetter <daniel at ffwll.ch> wrote:
> And that's some serious wtf. Yes we've done some compile-time type
> casting automagic between i915_priv and dev in the past, and I think even
> that was bad taste. But it was justified with that we have these
> everywhere (especially in the mmio macros), and it would be a terrible
> flag day.

FWIW, we had the dev_priv/dev macro trickery for a while to not have
that flag day conversion, until everything used i915 or &i915->drm. But
we got rid of it afterwards.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list