[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Pipe DMC Prep patches

Patchwork patchwork at emeril.freedesktop.org
Wed Apr 28 21:44:40 UTC 2021


== Series Details ==

Series: Pipe DMC Prep patches
URL   : https://patchwork.freedesktop.org/series/89602/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
32def90ad84d drm/i915/csr: s/DRM_ERROR/drm_err
-:38: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#38: FILE: drivers/gpu/drm/i915/display/intel_csr.c:445:
+		drm_err(&dev_priv->drm, "Unknown DMC fw header version: %u\n",
 			  dmc_header->header_ver);

-:61: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#61: FILE: drivers/gpu/drm/i915/display/intel_csr.c:465:
+			drm_err(&dev_priv->drm, "DMC firmware has wrong mmio address 0x%x\n",
 				  mmioaddr[i]);

-:77: WARNING:OOM_MESSAGE: Possible unnecessary 'out of memory' message
#77: FILE: drivers/gpu/drm/i915/display/intel_csr.c:488:
 	if (!csr->dmc_payload) {
+		drm_err(&dev_priv->drm, "Memory allocation failed for dmc payload\n");

-:102: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#102: FILE: drivers/gpu/drm/i915/display/intel_csr.c:521:
+		drm_err(&dev_priv->drm, "DMC firmware has unknown header version %u\n",
 			  package_header->header_ver);

-:120: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#120: FILE: drivers/gpu/drm/i915/display/intel_csr.c:549:
+		drm_err(&dev_priv->drm, "DMC firmware not supported for %c stepping\n",
 			  si->stepping);

total: 0 errors, 1 warnings, 4 checks, 165 lines checked
07e44e7c8997 drm/i915/csr: Add intel_csr_has_dmc_payload() helper
b18fa946a9e4 drm/i915/csr: Introduce DMC_FW_MAIN




More information about the Intel-gfx mailing list