[Intel-gfx] [PATCH] drm/i915: Include intel_de_{read, write}_fw() in i915_reg_rw traces

[Jani Nikula]

On Thu, 29 Apr 2021, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> On Thu, Apr 29, 2021 at 11:11:25AM +0300, Jani Nikula wrote:
>> On Thu, 29 Apr 2021, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
>> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>> >
>> > We lost the i915_reg_rw tracepoint for a lot of display registers
>> > when we switched from the heavyweight normal register accessors to
>> > the lightweight _fw() variants.
>> 
>> Sorry, which change was that exactly?
>
> commit dd584fc0711a ("drm/i915: Use I915_READ_FW for plane updates")
> and probably a few others like it.
>
>> 
>> > Put the tracepoints back so that
>> > the register traces might actually be useful. Hopefully these should
>> > be close to free when the tracepoint is not enabled and thus not
>> > slow down our vblank critical sections significantly.
>> >
>> > The biggest hurdle is untangling the include order. Fortunately just
>> > pulling intel_de.h out from intel_display_types.h seems to have been
>> > sufficient to make it build.
>> 
>> This is something I've been meaning to fix independently. Thanks.
>
> Hmm. Maybe I should split this into two commits...
>
>> 
>> Reviewed-by: Jani Nikula <jani.nikula at intel.com>
>
> Ta.

Rb holds whether you decide to split or not, up to you.

-- 
Jani Nikula, Intel Open Source Graphics Center