[Intel-gfx] [PATCH v8 1/5] drm/ast: Remove reference to struct drm_device.pdev

Thomas Zimmermann tzimmermann at suse.de
Thu Apr 29 19:22:27 UTC 2021


Hi

Am 29.04.21 um 18:04 schrieb Ruhl, Michael J:
> 
> 
>> -----Original Message-----
>> From: dri-devel <dri-devel-bounces at lists.freedesktop.org> On Behalf Of
>> Thomas Zimmermann
>> Sent: Thursday, April 29, 2021 6:51 AM
>> To: jani.nikula at linux.intel.com; joonas.lahtinen at linux.intel.com; Vivi, Rodrigo
>> <rodrigo.vivi at intel.com>; airlied at linux.ie; daniel at ffwll.ch; chris at chris-
>> wilson.co.uk
>> Cc: lkp <lkp at intel.com>; intel-gfx at lists.freedesktop.org; dri-
>> devel at lists.freedesktop.org; Thomas Zimmermann
>> <tzimmermann at suse.de>; Dave Airlie <airlied at redhat.com>
>> Subject: [PATCH v8 1/5] drm/ast: Remove reference to struct
>> drm_device.pdev
>>
>> Using struct drm_device.pdev is deprecated. Upcast with to_pci_dev()
>>from struct drm_device.dev to get the PCI device structure.
> 
> Reviewed-by: Michael J. Ruhl <michael.j.ruhl at intel.com>

Awesome! Thanks a lot for the timely response. I pushed everything into 
drm-misc-next before the bitrot sets in again.

Best regards
Thomas

> 
> m
> 
>> Signed-off-by: Thomas Zimmermann <tzimmermann at suse.de>
>> Fixes: ba4e0339a6a3 ("drm/ast: Fixed CVE for DP501")
>> Cc: KuoHsiang Chou <kuohsiang_chou at aspeedtech.com>
>> Cc: kernel test robot <lkp at intel.com>
>> Cc: Thomas Zimmermann <tzimmermann at suse.de>
>> Cc: Dave Airlie <airlied at redhat.com>
>> Cc: dri-devel at lists.freedesktop.org
>> ---
>> drivers/gpu/drm/ast/ast_main.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/ast/ast_main.c
>> b/drivers/gpu/drm/ast/ast_main.c
>> index 189d783f6e2c..6b49a92dc75f 100644
>> --- a/drivers/gpu/drm/ast/ast_main.c
>> +++ b/drivers/gpu/drm/ast/ast_main.c
>> @@ -411,7 +411,6 @@ struct ast_private *ast_device_create(const struct
>> drm_driver *drv,
>> 		return ast;
>> 	dev = &ast->base;
>>
>> -	dev->pdev = pdev;
>> 	pci_set_drvdata(pdev, dev);
>>
>> 	ast->regs = pcim_iomap(pdev, 1, 0);
>> --
>> 2.31.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20210429/0001e144/attachment.sig>


More information about the Intel-gfx mailing list