[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clean up GuC CI failures, simplify locking, and kernel DOC

Patchwork patchwork at emeril.freedesktop.org
Sun Aug 15 20:33:26 UTC 2021


== Series Details ==

Series: Clean up GuC CI failures, simplify locking, and kernel DOC
URL   : https://patchwork.freedesktop.org/series/93704/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c9f3859e5dce drm/i915/guc: Fix blocked context accounting
7fe738f56abc drm/i915/guc: outstanding G2H accounting
1d414637d838 drm/i915/guc: Unwind context requests in reverse order
2739b8f8966f drm/i915/guc: Don't drop ce->guc_active.lock when unwinding context
8ec967ce47da drm/i915/guc: Workaround reset G2H is received after schedule done G2H
-:7: WARNING:TYPO_SPELLING: 'cancelation' may be misspelled - perhaps 'cancellation'?
#7: 
If the context is reset as a result of the request cancelation the
                                                   ^^^^^^^^^^^

-:10: WARNING:TYPO_SPELLING: 'cancelation' may be misspelled - perhaps 'cancellation'?
#10: 
waiting request cancelation code which resubmits the context. This races
                ^^^^^^^^^^^

-:12: WARNING:TYPO_SPELLING: 'cancelation' may be misspelled - perhaps 'cancellation'?
#12: 
in this case it really should be a NOP as request cancelation code owns
                                                  ^^^^^^^^^^^

-:43: WARNING:TYPO_SPELLING: 'cancelation' may be misspelled - perhaps 'cancellation'?
#43: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:840:
+	 * XXX: If the context is reset as a result of the request cancelation
 	                                                           ^^^^^^^^^^^

-:45: WARNING:TYPO_SPELLING: 'cancelation' may be misspelled - perhaps 'cancellation'?
#45: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:842:
+	 * likely wrong as this creates a race between the request cancelation
 	                                                           ^^^^^^^^^^^

-:49: WARNING:TYPO_SPELLING: 'cancelation' may be misspelled - perhaps 'cancellation'?
#49: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:846:
+	 * enable is in flight as this indicates that a request cancelation has
 	                                                        ^^^^^^^^^^^

-:50: WARNING:TYPO_SPELLING: 'occured' may be misspelled - perhaps 'occurred'?
#50: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:847:
+	 * occured.
 	   ^^^^^^^

-:92: WARNING:TYPO_SPELLING: 'cancelation' may be misspelled - perhaps 'cancellation'?
#92: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:2748:
+	 * XXX: Racey if request cancelation has occurred, see comment in
 	                         ^^^^^^^^^^^

total: 0 errors, 8 warnings, 0 checks, 72 lines checked
0c0928ba1ba8 drm/i915/selftests: Add a cancel request selftest that triggers a reset
c18da32e671c drm/i915/guc: Don't enable scheduling on a banned context, guc_id invalid, not registered
cddf94c9bda0 drm/i915/selftests: Fix memory corruption in live_lrc_isolation
b5e8c08dff35 drm/i915/selftests: Add initial GuC selftest for scrubbing lost G2H
-:101: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#101: 
new file mode 100644

-:161: ERROR:SPACING: space required before the open parenthesis '('
#161: FILE: drivers/gpu/drm/i915/gt/uc/selftest_guc.c:56:
+		switch(i) {

total: 1 errors, 1 warnings, 0 checks, 232 lines checked
b929abcf3b59 drm/i915/guc: Take context ref when cancelling request
025e88fa74d3 drm/i915/guc: Don't touch guc_state.sched_state without a lock
6c1c488a3654 drm/i915/guc: Reset LRC descriptor if register returns -ENODEV
c0ad63d810e6 drm/i915: Allocate error capture in atomic context
14dc302536e1 drm/i915/guc: Flush G2H work queue during reset
1c2b4c0ac62a drm/i915/guc: Release submit fence from an IRQ
4c980575f7af drm/i915/guc: Move guc_blocked fence to struct guc_state
d97ab34c8bac drm/i915/guc: Rework and simplify locking
7057a0daff8c drm/i915/guc: Proper xarray usage for contexts_lookup
-:27: WARNING:LINE_SPACING: Missing a blank line after declarations
#27: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_submission.c:610:
+		bool do_put = kref_get_unless_zero(&ce->ref);
+		xa_unlock(&guc->context_lookup);

total: 0 errors, 1 warnings, 0 checks, 187 lines checked
eb8a352e7c1f drm/i915/guc: Drop pin count check trick between sched_disable and re-pin
af14e3698d19 drm/i915/guc: Move GuC priority fields in context under guc_active
f7ff315bfe3a drm/i915/guc: Add GuC kernel doc




More information about the Intel-gfx mailing list