[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: better backlight & panel abstractions

Patchwork patchwork at emeril.freedesktop.org
Wed Aug 25 12:13:49 UTC 2021


== Series Details ==

Series: drm/i915: better backlight & panel abstractions
URL   : https://patchwork.freedesktop.org/series/94004/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
46e4b18ff71c drm/i915/backlight: extract backlight code to a separate file
-:58: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#58: 
new file mode 100644

-:263: WARNING:LINE_SPACING: Missing a blank line after declarations
#263: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:201:
+	u32 val = intel_de_read(dev_priv, BLC_PWM_PCH_CTL2) & ~BACKLIGHT_DUTY_CYCLE_MASK;
+	intel_de_write(dev_priv, BLC_PWM_PCH_CTL2, val | level);

-:1823: WARNING:BRACES: braces {} are not necessary for any arm of this statement
#1823: FILE: drivers/gpu/drm/i915/display/intel_backlight.c:1761:
+		if (connector->base.connector_type == DRM_MODE_CONNECTOR_DSI) {
[...]
+		} else {
[...]

-:1892: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#1892: FILE: drivers/gpu/drm/i915/display/intel_backlight.h:46:
+}
+static inline void intel_backlight_device_unregister(struct intel_connector *connector)

total: 0 errors, 3 warnings, 1 checks, 3769 lines checked
46ca4e1f64e6 drm/i915/backlight: mass rename functions to have intel_backlight_ prefix
-:558: WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#558: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:241:
+	panel->backlight.pwm_funcs->disable(conn_state, intel_backlight_invert_pwm_level(connector, 0));

total: 0 errors, 1 warnings, 0 checks, 568 lines checked
65bd1bc02fc9 drm/i915/panel: mass rename functions to have intel_panel_ prefix




More information about the Intel-gfx mailing list