[Intel-gfx] [PATCH 5/5] drm/i915/debugfs: pass intel_connector to intel_connector_debugfs_add()
kernel test robot
lkp at intel.com
Tue Aug 31 16:00:02 UTC 2021
Hi Jani,
I love your patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip next-20210831]
[cannot apply to v5.14]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Jani-Nikula/drm-i915-display-debugfs-cleanups/20210830-205450
base: git://anongit.freedesktop.org/drm-intel for-linux-next
config: i386-randconfig-a014-20210831 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 4b1fde8a2b681dad2ce0c082a5d6422caa06b0bc)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/3398bb6468f037af818548e7987e8fd062278824
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Jani-Nikula/drm-i915-display-debugfs-cleanups/20210830-205450
git checkout 3398bb6468f037af818548e7987e8fd062278824
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/i915/display/intel_connector.c:127:30: error: incompatible pointer types passing 'struct intel_connector *' to parameter of type 'struct drm_connector *' [-Werror,-Wincompatible-pointer-types]
intel_connector_debugfs_add(intel_connector);
^~~~~~~~~~~~~~~
drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:56: note: passing argument to parameter 'connector' here
void intel_connector_debugfs_add(struct drm_connector *connector);
^
1 error generated.
--
>> drivers/gpu/drm/i915/display/intel_display_debugfs.c:2447:6: error: conflicting types for 'intel_connector_debugfs_add'
void intel_connector_debugfs_add(struct intel_connector *intel_connector)
^
drivers/gpu/drm/i915/display/intel_display_debugfs.h:15:6: note: previous declaration is here
void intel_connector_debugfs_add(struct drm_connector *connector);
^
1 error generated.
vim +127 drivers/gpu/drm/i915/display/intel_connector.c
112
113 int intel_connector_register(struct drm_connector *connector)
114 {
115 struct intel_connector *intel_connector = to_intel_connector(connector);
116 int ret;
117
118 ret = intel_backlight_device_register(intel_connector);
119 if (ret)
120 goto err;
121
122 if (i915_inject_probe_failure(to_i915(connector->dev))) {
123 ret = -EFAULT;
124 goto err_backlight;
125 }
126
> 127 intel_connector_debugfs_add(intel_connector);
128
129 return 0;
130
131 err_backlight:
132 intel_backlight_device_unregister(intel_connector);
133 err:
134 return ret;
135 }
136
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 35366 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20210901/c1afd5c1/attachment-0001.gz>
More information about the Intel-gfx
mailing list