[Intel-gfx] [PATCH 1/4] drm/i915: Add has_64k_pages flag
Andi Shyti
andi.shyti at linux.intel.com
Wed Dec 8 16:08:00 UTC 2021
Hi Ram,
Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>
but just two notes on the patchstyle, no need to resend:
1. would be nice to have [PATCH v2...] otherwise it's difficult
to see if I'm reading the correct version. (I don't see the
difficulty 'git format-patch -v 2...')
> Add a new platform flag, has_64k_pages, to mark the requirement of 64K
> GTT page sizes or larger for device local memory access.
>
> Also implies that we require or at least support the compact PT layout
> for the ppGTT when using 64K GTT pages.
>
> v2: More explanation for the flag [Thomas]
>
> Signed-off-by: Stuart Summers <stuart.summers at intel.com>
> Signed-off-by: Ramalingam C <ramalingam.c at intel.com>
> Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
2. the tag part has a temporal meaning: Stuart has written the
patch, Lucas has reviewed it and you are sending it,
therefore, the correct order should be:
Signed-off-by: Stuart Summers <stuart.summers at intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>
Signed-off-by: Ramalingam C <ramalingam.c at intel.com>
Thanks,
Andi
More information about the Intel-gfx
mailing list