[Intel-gfx] [PATCH 1/3] drm/i915: Nuke {pipe, plane}_to_crtc_mapping[]

Ville Syrjälä ville.syrjala at linux.intel.com
Thu Dec 9 13:24:13 UTC 2021


On Thu, Dec 09, 2021 at 03:14:52PM +0200, Jani Nikula wrote:
> On Fri, 03 Dec 2021, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> >
> > These plane/pipe->crtc mapping arrays are rather pointless.
> > Get rid of them and just iterate the lists instead.
> 
> Nice follow-up to my cleanups. On the series,
> 
> Reviewed-by: Jani Nikula <jani.nikula at intel.com>
> 
> intel_crtc_first() might have been nice for the prefix, but does it
> sound too awkward? *shrug*

Yeah, sounds a bit wonky to my ear.

I'd probably have of those "wtf does that do?" moments if I saw
a intel_crtc_first() call in the code.

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list