[Intel-gfx] [PATCH v6 01/11] drm/i915: Store backpointer to GT in uncore
Andi Shyti
andi.shyti at linux.intel.com
Thu Dec 9 17:26:00 UTC 2021
Hi Jani,
thanks for looking at it.
> > - intel_gt_init_early(&dev_priv->gt, dev_priv);
> > + __intel_gt_init_early(&dev_priv->gt, dev_priv);
>
> Why double underscores here? It looks like it's supposed to be internal
> to intel_gt, not to be called by anyone else.
I forgot to write two lines in the commit log about this.
It's a temporary solution that will go away in the next patch
series[*].
The reason for it is because at this point I need to break the
early initialization of the gt into two parts. In the specific
the '__intel_gt_init_early' assigns the i915 private data and the
uncore.
It's not pretty, but, knowing what's coming next, it's the change
with the smallest impact.
> >
> > i915_gem_init_early(dev_priv);
> >
Thank you,
Andi
[*] https://patchwork.freedesktop.org/patch/464475/?series=97352&rev=1
More information about the Intel-gfx
mailing list