[Intel-gfx] [PATCH v3 2/2] drm/i915/trace: split out display trace to a separate file

[Lucas De Marchi]

On Wed, Dec 08, 2021 at 06:39:55PM +0200, Jani Nikula wrote:
>On Wed, 08 Dec 2021, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
>> On Wed, Dec 08, 2021 at 01:05:17PM +0200, Jani Nikula wrote:
>>>Add display/intel_display_trace.[ch] for defining display
>>>tracepoints. The main goal is to reduce cross-includes between gem and
>>>display. It would be possible split up tracing even further, but that
>>>would lead to more boilerplate.
>>>
>>>We end up having to include intel_crtc.h in a few places because it was
>>>pulled in implicitly via intel_de.h -> i915_trace.h -> intel_crtc.h, and
>>>that's no longer the case.
>>>
>>>There should be no changes to tracepoints.
>>>
>>>v3:
>>>- Rebase
>>>
>>>v2:
>>>- Define TRACE_INCLUDE_PATH relative to define_trace.h (Chris)
>>>- Remove useless comments (Ville)
>>>
>>>Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
>>>Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>>>Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
>>
>>
>> only thing I noticed in the code move is that we lost the comments about
>> grouping the tracepoints. Was this intentional? Example:
>
>Yeah, specifically requested by Ville (see v2 changelog above).


ah, ok. Thanks.

Lucas De Marchi