[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove short term pins from execbuf by requiring lock to unbind.

Patchwork patchwork at emeril.freedesktop.org
Fri Dec 17 08:46:35 UTC 2021


== Series Details ==

Series: drm/i915: Remove short term pins from execbuf by requiring lock to unbind.
URL   : https://patchwork.freedesktop.org/series/98137/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
bc08f58eeb3f drm/i915: Remove unused bits of i915_vma/active api
91bcecf270f0 drm/i915: Change shrink ordering to use locking around unbinding.
-:28: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#28: FILE: drivers/gpu/drm/i915/gem/i915_gem_shrinker.c:40:
+static int drop_pages(struct drm_i915_gem_object *obj,
+		       unsigned long shrink, bool trylock_vm)

total: 0 errors, 0 warnings, 1 checks, 52 lines checked
316d336c98ea drm/i915: Remove pages_mutex and intel_gtt->vma_ops.set/clear_pages members, v3.
9d385c135ad3 drm/i915: Take object lock in i915_ggtt_pin if ww is not set
c293606bcd36 drm/i915: Force ww lock for i915_gem_object_ggtt_pin_ww, v2.
e7fbd118c9b2 drm/i915: Ensure gem_contexts selftests work with unbind changes, v2.
c9892c726d3c drm/i915: Ensure i915_vma tests do not get -ENOSPC with the locking changes.
cc5dd7eac42f drm/i915: Call i915_gem_evict_vm in vm_fault_gtt to prevent new ENOSPC errors
1631c2059017 drm/i915: Trylock the object when shrinking
d1406f612444 drm/i915: Require object lock when freeing pages during destruction
97cc19bfa2a0 drm/i915: Add ww ctx to i915_gem_object_trylock
44fc65c4b062 drm/i915: Add locking to i915_gem_evict_vm()
8b8d9bb4ffaa drm/i915: Add object locking to i915_gem_evict_for_node and i915_gem_evict_something
-:148: CHECK:LINE_SPACING: Please don't use multiple blank lines
#148: FILE: drivers/gpu/drm/i915/i915_gem_evict.c:252:
 
+

total: 0 errors, 0 warnings, 1 checks, 364 lines checked
d2242714f33e drm/i915: Add i915_vma_unbind_unlocked, and take obj lock for i915_vma_unbind, v2.
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
We want to remove more members of i915_vma, which requires the locking to be

total: 0 errors, 1 warnings, 0 checks, 317 lines checked
ece7fb471984 drm/i915: Remove assert_object_held_shared
d5c98a7587ba drm/i915: Remove support for unlocked i915_vma unbind
c54bb29dd0de drm/i915: Remove short-term pins from execbuf, v5.




More information about the Intel-gfx mailing list