[Intel-gfx] [PATCH 00/15] drm/i915: Clean up the DDI clock routing mess

[Lucas De Marchi]

On Mon, Feb 01, 2021 at 08:33:28PM +0200, Ville Syrjälä wrote:
>From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
>The DDI clock routing code has turned into proper spaghetti.
>Attempt to clean it up by introducing some new vfuncs.

A few minors I replied in the series. The move back and forth from one
approach to the other IMO makes it harder to review, but after looking
that the complete set:

Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>
>Ville Syrjälä (15):
>  drm/i915: Extract icl_dpclka_cfgcr0_reg()
>  drm/i915: Extract icl_dpclka_cfgcr0_clk_sel*()
>  drm/i915: Introduce .{enable,disable}_clock() encoder vfuncs
>  drm/i915: Extract hsw_ddi_{enable,disable}_clock()
>  drm/i915: Extract skl_ddi_{enable,disable}_clock()
>  drm/i195: Extract cnl_ddi_{enable,disable}_clock()
>  drm/i915: Convert DG1 over to .{enable,disable}_clock()
>  drm/i915: Extract icl+ .{enable,disable}_clock() vfuncs
>  drm/i915: Use intel_de_rmw() for DDI clock routing
>  drm/i915: Sprinkle a few missing locks around shared DDI clock
>    registers
>  drm/i915: Sprinkle WARN(!pll) into icl/dg1 .clock_enable()
>  drm/i915: Extract _cnl_ddi_{enable,disable}_clock()
>  drm/i915: Split alds/rkl from icl_ddi_combo_{enable,disable}_clock()
>  drm/i915: Use .disable_clock() for pll sanitation
>  drm/i915: Relocate icl_sanitize_encoder_pll_mapping()
>
> drivers/gpu/drm/i915/display/icl_dsi.c        |   1 +
> drivers/gpu/drm/i915/display/intel_ddi.c      | 536 ++++++++++--------
> .../drm/i915/display/intel_display_types.h    |   6 +
> 3 files changed, 295 insertions(+), 248 deletions(-)
>
>-- 
>2.26.2
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx at lists.freedesktop.org
>https://lists.freedesktop.org/mailman/listinfo/intel-gfx