[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v14,1/2] drm/i915/display: Support PSR Multiple Instances
Mun, Gwan-gyeong
gwan-gyeong.mun at intel.com
Tue Feb 2 14:42:17 UTC 2021
On Fri, 2021-01-29 at 11:45 +0000, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [v14,1/2] drm/i915/display: Support PSR
> Multiple Instances
> URL : https://patchwork.freedesktop.org/series/86445/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> e7df7e13f87c drm/i915/display: Support PSR Multiple Instances
> -:88: ERROR:COMPLEX_MACRO: Macros with complex values should be
> enclosed in parentheses
> #88: FILE: drivers/gpu/drm/i915/display/intel_display.h:420:
> +#define for_each_intel_encoder_mask_can_psr(dev, intel_encoder,
> encoder_mask) \
> + list_for_each_entry((intel_encoder), &(dev)-
> >mode_config.encoder_list, base.head) \
> + for_each_if(((encoder_mask) &
> drm_encoder_mask(&(intel_encoder)->base)) && \
> + intel_encoder_can_psr(intel_encoder))
>
> -:88: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' -
> possible side-effects?
> #88: FILE: drivers/gpu/drm/i915/display/intel_display.h:420:
> +#define for_each_intel_encoder_mask_can_psr(dev, intel_encoder,
> encoder_mask) \
> + list_for_each_entry((intel_encoder), &(dev)-
> >mode_config.encoder_list, base.head) \
> + for_each_if(((encoder_mask) &
> drm_encoder_mask(&(intel_encoder)->base)) && \
> + intel_encoder_can_psr(intel_encoder))
>
> -:97: ERROR:COMPLEX_MACRO: Macros with complex values should be
> enclosed in parentheses
> #97: FILE: drivers/gpu/drm/i915/display/intel_display.h:429:
> +#define for_each_intel_encoder_can_psr(dev, intel_encoder) \
> + for_each_intel_encoder((dev), (intel_encoder)) \
> + for_each_if(intel_encoder_can_psr(intel_encoder))
>
> -:97: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' -
> possible side-effects?
> #97: FILE: drivers/gpu/drm/i915/display/intel_display.h:429:
> +#define for_each_intel_encoder_can_psr(dev, intel_encoder) \
> + for_each_intel_encoder((dev), (intel_encoder)) \
> + for_each_if(intel_encoder_can_psr(intel_encoder))
>
> -:375: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_dp' -
> possible side-effects?
> #375: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1795:
> +#define CAN_PSR(intel_dp) (HAS_PSR(dp_to_i915(intel_dp)) && \
> + (intel_dp)->psr.sink_support && \
> + (intel_dp)->psr.source_support)
>
> total: 2 errors, 0 warnings, 3 checks, 1730 lines checked
> 02d0fee29897 drm/i915/display: Support Multiple Transcoders' PSR
> status on debugfs
>
>
The reported error related code are followed other intel display.h's
macro style and it is intended code.
More information about the Intel-gfx
mailing list