[Intel-gfx] [PATCH v2 3/3] drm/i915/gtt/dg1: add PTE_LM plumbing for GGTT

[Chris Wilson]

Quoting Matthew Auld (2021-02-03 14:13:13)
> diff --git a/drivers/gpu/drm/i915/gt/intel_gtt.h b/drivers/gpu/drm/i915/gt/intel_gtt.h
> index 4a1d9b5cc75b..55873663d37f 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gtt.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gtt.h
> @@ -85,7 +85,8 @@ typedef u64 gen8_pte_t;
>  #define BYT_PTE_SNOOPED_BY_CPU_CACHES  REG_BIT(2)
>  #define BYT_PTE_WRITEABLE              REG_BIT(1)
>  
> -#define GEN12_PPGTT_PTE_LM (1 << 11)
> +#define GEN12_GGTT_PTE_LM      (1 << 1)
> +#define GEN12_PPGTT_PTE_LM     (1 << 11)

Too subtle. Leave a line between the different GTT.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris