[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for swiotlb: 64-bit DMA buffer

Patchwork patchwork at emeril.freedesktop.org
Thu Feb 4 19:53:14 UTC 2021


== Series Details ==

Series: swiotlb: 64-bit DMA buffer
URL   : https://patchwork.freedesktop.org/series/86700/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
e188296818db swiotlb: define new enumerated type
50f74bc8af02 swiotlb: convert variables to arrays
-:130: WARNING:CONSIDER_KSTRTO: simple_strtoul is obsolete, use kstrtoul instead
#130: FILE: kernel/dma/swiotlb.c:116:
+		io_tlb_nslabs[SWIOTLB_LO] = simple_strtoul(str, &str, 0);

-:591: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#591: FILE: kernel/dma/swiotlb.c:589:
+		io_tlb_orig_addr[SWIOTLB_LO][index+i] = orig_addr + (i << IO_TLB_SHIFT);
 		                                  ^

total: 0 errors, 1 warnings, 1 checks, 602 lines checked
7fe9ad150961 swiotlb: introduce swiotlb_get_type() to calculate swiotlb buffer type
eb9848ac2c6c swiotlb: enable 64-bit swiotlb
-:227: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#227: FILE: include/linux/swiotlb.h:48:
+extern unsigned long swiotlb_nr_tbl(enum swiotlb_t type);

-:231: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#231: FILE: include/linux/swiotlb.h:50:
+extern int swiotlb_late_init_with_tbl(char *tlb, unsigned long nslabs,

-:233: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#233: FILE: include/linux/swiotlb.h:52:
+extern int swiotlb_late_init_with_default_size(size_t default_size,

-:268: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#268: FILE: include/linux/swiotlb.h:123:
 }
+static inline unsigned int swiotlb_max_segment(enum swiotlb_t type)

-:278: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#278: FILE: include/linux/swiotlb.h:142:
+extern void swiotlb_print_info(enum swiotlb_t type);

-:279: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files
#279: FILE: include/linux/swiotlb.h:143:
+extern void swiotlb_set_max_segment(unsigned int val, enum swiotlb_t type);

-:304: WARNING:CONSIDER_KSTRTO: simple_strtoul is obsolete, use kstrtoul instead
#304: FILE: kernel/dma/swiotlb.c:131:
+		io_tlb_nslabs[SWIOTLB_HI] = simple_strtoul(str, &str, 0);

-:840: CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#840: FILE: kernel/dma/swiotlb.c:641:
+		io_tlb_orig_addr[type][index+i] = orig_addr + (i << IO_TLB_SHIFT);
 		                            ^

total: 0 errors, 1 warnings, 7 checks, 790 lines checked
30d8a3cce117 xen-swiotlb: convert variables to arrays
-:110: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#110: FILE: drivers/xen/swiotlb-xen.c:208:
+		xen_io_tlb_start[SWIOTLB_LO] = memblock_alloc(PAGE_ALIGN(bytes),
 						  PAGE_SIZE);

total: 0 errors, 0 warnings, 1 checks, 181 lines checked
3a347e83afb9 xen-swiotlb: enable 64-bit xen-swiotlb
-:83: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#83: FILE: drivers/xen/swiotlb-xen.c:165:
+		xen_io_tlb_nslabs[type] = ALIGN(xen_io_tlb_nslabs[type],
 						      IO_TLB_SEGSIZE);

-:130: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#130: FILE: drivers/xen/swiotlb-xen.c:219:
+		xen_io_tlb_start[type] = memblock_alloc(PAGE_ALIGN(bytes),
 						  PAGE_SIZE);

total: 0 errors, 0 warnings, 2 checks, 235 lines checked




More information about the Intel-gfx mailing list