[Intel-gfx] [PATCH] drm/i915/display: Remove PSR2 on JSL and EHL

Souza, Jose jose.souza at intel.com
Thu Feb 4 20:21:08 UTC 2021


On Thu, 2021-02-04 at 09:58 -0800, José Roberto de Souza wrote:
> From: Edmund Dea <edmund.j.dea at intel.com>
> 
> While JSL and EHL eDP transcoder supports PSR2, the phy of this
> platforms only supports eDP 1.3, so removing PSR2 support as this
> feature was added in eDP 1.4.

Just sent a patch from Edmund with a minor commit message tweaks, so I guess my rvb is valid if not please let me know.

Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

> 
> Signed-off-by: Edmund Dea <edmund.j.dea at intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 2c365b778f74..cccb8aff4336 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -718,6 +718,12 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
>  	if (!dev_priv->psr.sink_psr2_support)
>  		return false;
>  
> 
> 
> 
> +	/* JSL and EHL only supports eDP 1.3 */
> +	if (IS_JSL_EHL(dev_priv)) {
> +		drm_dbg_kms(&dev_priv->drm, "PSR2 not supported by phy\n");
> +		return false;
> +	}
> +
>  	if (!transcoder_has_psr2(dev_priv, crtc_state->cpu_transcoder)) {
>  		drm_dbg_kms(&dev_priv->drm,
>  			    "PSR2 not supported in transcoder %s\n",



More information about the Intel-gfx mailing list