[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/display: Rename for_each_intel_encoder.*_can_psr to for_each_intel_encoder.*_with_psr
Patchwork
patchwork at emeril.freedesktop.org
Tue Feb 9 18:26:01 UTC 2021
== Series Details ==
Series: series starting with [1/4] drm/i915/display: Rename for_each_intel_encoder.*_can_psr to for_each_intel_encoder.*_with_psr
URL : https://patchwork.freedesktop.org/series/86910/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1edc3ad07376 drm/i915/display: Rename for_each_intel_encoder.*_can_psr to for_each_intel_encoder.*_with_psr
-:25: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#25: FILE: drivers/gpu/drm/i915/display/intel_display.h:421:
+#define for_each_intel_encoder_mask_with_psr(dev, intel_encoder, encoder_mask) \
list_for_each_entry((intel_encoder), &(dev)->mode_config.encoder_list, base.head) \
for_each_if(((encoder_mask) & drm_encoder_mask(&(intel_encoder)->base)) && \
intel_encoder_can_psr(intel_encoder))
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' - possible side-effects?
#25: FILE: drivers/gpu/drm/i915/display/intel_display.h:421:
+#define for_each_intel_encoder_mask_with_psr(dev, intel_encoder, encoder_mask) \
list_for_each_entry((intel_encoder), &(dev)->mode_config.encoder_list, base.head) \
for_each_if(((encoder_mask) & drm_encoder_mask(&(intel_encoder)->base)) && \
intel_encoder_can_psr(intel_encoder))
-:34: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#34: FILE: drivers/gpu/drm/i915/display/intel_display.h:430:
+#define for_each_intel_encoder_with_psr(dev, intel_encoder) \
for_each_intel_encoder((dev), (intel_encoder)) \
for_each_if(intel_encoder_can_psr(intel_encoder))
-:34: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_encoder' - possible side-effects?
#34: FILE: drivers/gpu/drm/i915/display/intel_display.h:430:
+#define for_each_intel_encoder_with_psr(dev, intel_encoder) \
for_each_intel_encoder((dev), (intel_encoder)) \
for_each_if(intel_encoder_can_psr(intel_encoder))
total: 2 errors, 0 warnings, 2 checks, 92 lines checked
fe6bbcba6125 drm/i915/display: Only write to register in intel_psr2_program_trans_man_trk_ctl()
889eeb0a82dd drm/i915/display: Remove some redundancy around CAN_PSR()
-:29: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'intel_dp' - possible side-effects?
#29: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:1796:
+#define CAN_PSR(intel_dp) ((intel_dp)->psr.sink_support && \
+ (intel_dp)->psr.source_support)
total: 0 errors, 0 warnings, 1 checks, 35 lines checked
6c507f7a8c35 drm/i915/display: Set source_support even if panel do not support PSR
More information about the Intel-gfx
mailing list