[Intel-gfx] [PATCH] drm/i915/gem: Add a check for object size for corner cases

Chris Wilson chris at chris-wilson.co.uk
Wed Feb 10 10:45:06 UTC 2021


Quoting Anand Moon (2021-02-10 07:59:29)
> Add check for object size to return appropriate error -E2BIG or -EINVAL
> to avoid WARM_ON and sucessfull return for some testcase.

No. You miss the point of having those warnings. We need to inspect the
code to remove the last remaining "int pagenum", and then we can remove
the GEM_WARN_ON((sz) >> PAGE_SHIFT > INT_MAX). These are not emitted for
users, only for us to motivate us into finally fixing the code.
-Chris


More information about the Intel-gfx mailing list