[Intel-gfx] [PATCH] drm/i915/display: Compute aux ch power domain during DDI initialization

[Imre Deak]

On Wed, Feb 17, 2021 at 09:50:13PM +0200, Souza, Jose wrote:
> On Wed, 2021-02-17 at 21:38 +0200, Imre Deak wrote:
> > On Wed, Feb 17, 2021 at 10:02:45AM -0800, José Roberto de Souza wrote:
> > > [...]
> > > diff --git a/drivers/gpu/drm/i915/display/intel_display_types.h b/drivers/gpu/drm/i915/display/intel_display_types.h
> > > index 07b7f5eae587..d527cb2ad070 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_display_types.h
> > > +++ b/drivers/gpu/drm/i915/display/intel_display_types.h
> > > @@ -1589,6 +1589,8 @@ struct intel_digital_port {
> > >  	/* Used for DP and ICL+ TypeC/DP and TypeC/HDMI ports. */
> > >  	enum aux_ch aux_ch;
> > >  	enum intel_display_power_domain ddi_io_power_domain;
> > > +	/* Regular/legacy aux channel power domain */
> > > +	enum intel_display_power_domain aux_power_domain;
> > 
> > What's the rational for storing it here? If there's a good one then I'd
> > rather call this legacy_aux_power_domain and store the tbt aux domains
> > here as well. It would also need to get initialized for dp encoders.
> 
> This is a preparation for a future platform that will need a different
> aux power domain that do not mach with aux ch id.

Ok, makes sense then.

> Yeah I missed the initialization for non-DDI platforms.
> 
> > 
> > >  	intel_wakeref_t ddi_io_wakeref;
> > >  	intel_wakeref_t aux_wakeref;
> > >  	struct mutex tc_lock;	/* protects the TypeC port mode */
> > > diff --git a/drivers/gpu/drm/i915/display/intel_tc.c b/drivers/gpu/drm/i915/display/intel_tc.c
> > > index 2cefc13535a0..83080e15ad7a 100644
> > > --- a/drivers/gpu/drm/i915/display/intel_tc.c
> > > +++ b/drivers/gpu/drm/i915/display/intel_tc.c
> > > @@ -29,7 +29,7 @@ tc_cold_get_power_domain(struct intel_digital_port *dig_port)
> > >  	struct drm_i915_private *i915 = to_i915(dig_port->base.base.dev);
> > >  
> > > 
> > >  	if (INTEL_GEN(i915) == 11)
> > > -		return intel_legacy_aux_to_power_domain(dig_port->aux_ch);
> > > +		return dig_port->aux_power_domain;
> > >  	else
> > >  		return POWER_DOMAIN_TC_COLD_OFF;
> > >  }
> > > -- 
> > > 2.30.1
> > > 
>