[Intel-gfx] [PATCH 1/4] drm/i915/selftests: Break out of the lrc layout test after register mismatch

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Jan 6 15:28:01 UTC 2021


On 06/01/2021 15:17, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2021-01-06 15:10:02)
>>
>> On 06/01/2021 12:39, Chris Wilson wrote:
>>> AFter detecting a register mismatch between the protocontext and the
>>> image generated by HW, immediately break out of the double loop.
>>> (Otherwise we end up a second configuing error message.)
>>
>> s/configuing/confusing/?
>>
>> No use of dumping all differences? Why it is confusing?
> 
> rcs0: Different registers found at dword 2, expected 2244, found 2244
> rcs0: Expected LRI command at dword 2, found 00002244
> 
> We then hexdump the entire page, both HW/SW, so we can try and figure out
> what went wrong.

Right, I see it now.

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Regards,

Tvrtko




More information about the Intel-gfx mailing list