[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add support for Intel's eDP backlight controls (rev7)
Patchwork
patchwork at emeril.freedesktop.org
Wed Jan 6 19:05:26 UTC 2021
== Series Details ==
Series: drm/i915: Add support for Intel's eDP backlight controls (rev7)
URL : https://patchwork.freedesktop.org/series/81702/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1b13d103ba78 drm/i915: Keep track of pwm-related backlight hooks separately
-:593: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#593: FILE: drivers/gpu/drm/i915/display/intel_panel.c:1815:
+ panel->backlight.pwm_level_max = intel_de_read(dev_priv,
+ BXT_BLC_PWM_FREQ(panel->backlight.controller));
-:634: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#634: FILE: drivers/gpu/drm/i915/display/intel_panel.c:1849:
+ panel->backlight.pwm_level_max = intel_de_read(dev_priv,
+ BXT_BLC_PWM_FREQ(panel->backlight.controller));
total: 0 errors, 0 warnings, 2 checks, 740 lines checked
032bad0af7a4 drm/i915/dp: Enable Intel's HDR backlight interface (only SDR for now)
-:162: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#162: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:149:
+ return panel->backlight.max;
+ } else {
-:202: WARNING:LINE_SPACING: Missing a blank line after declarations
#202: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:189:
+ const u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+ intel_panel_set_pwm_level(conn_state, pwm_level);
-:229: WARNING:LINE_SPACING: Missing a blank line after declarations
#229: FILE: drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c:216:
+ u32 pwm_level = intel_panel_backlight_level_to_pwm(connector, level);
+ panel->backlight.pwm_funcs->enable(crtc_state, conn_state, pwm_level);
total: 0 errors, 3 warnings, 0 checks, 401 lines checked
34119292a8b4 drm/i915/dp: Allow forcing specific interfaces through enable_dpcd_backlight
74a4b209e175 drm/dp: Revert "drm/dp: Introduce EDID-based quirks"
More information about the Intel-gfx
mailing list