[Intel-gfx] [PATCH v3] drm/i915/gt: Remove timeslice suppression
andi at etezian.org
Thu Jan 7 11:34:07 UTC 2021
On Thu, Jan 07, 2021 at 11:05:55AM +0000, Chris Wilson wrote:
> In the next^W future patch, we remove the strict priority system and
> continuously re-evaluate the relative priority of tasks. As such we need
> to enable the timeslice whenever there is more than one context in the
> pipeline. This simplifies the decision and removes some of the tweaks to
> suppress timeslicing, allowing us to lift the timeslice enabling to a
> common spot at the end of running the submission tasklet.
> One consequence of the suppression is that it was reducing fairness
> between virtual engines on an over saturated system; undermining the
> principle for timeslicing.
> v2: Commentary
> v3: Commentary for the right cancel_timer()
> Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2802
> Testcase: igt/gem_exec_balancer/fairslice
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
I don't know if you have answered all Tvrtko's question, but I
to me this looks good.
Reviewed-by: Andi Shyti <andi.shyti at intel.com>
More information about the Intel-gfx