[Intel-gfx] [PATCH 01/13] drm/i915/pps: abstract panel power sequencer from intel_dp.c
jani.nikula at intel.com
Fri Jan 8 17:44:52 UTC 2021
On Mon, 04 Jan 2021, Jani Nikula <jani.nikula at intel.com> wrote:
> On Mon, 28 Dec 2020, "Gupta, Anshuman" <anshuman.gupta at intel.com> wrote:
>>> -----Original Message-----
>>> From: Intel-gfx <intel-gfx-bounces at lists.freedesktop.org> On Behalf Of Jani
>>> Sent: Tuesday, December 22, 2020 8:20 PM
>>> To: intel-gfx at lists.freedesktop.org
>>> Cc: Nikula, Jani <jani.nikula at intel.com>
>>> Subject: [Intel-gfx] [PATCH 01/13] drm/i915/pps: abstract panel power
>>> sequencer from intel_dp.c
>>> In a long overdue refactoring, split out all panel sequencer code from
>>> intel_dp.c to new intel_pps.[ch].
>>> The first part is mostly just code movement as-is, without cleanups.
>>> We need to add a vlv_get_dpll() helper to get at the vlv/chv dpll from
>>> pps code.
>> IMHO functions intel_dp_init_panel_power_sequencer, intel_dp_init_panel_power_sequencer_registers,
>> intel_dp_pps_init suits a intel_edp_* prefix.
> This patch just moves code. The rename would be a separate change on
> top. Possibly with intel_pps prefix instead because they're not so much
> about dp or edp as about pps.
I've added some additional renames in v2.
Jani Nikula, Intel Open Source Graphics Center
More information about the Intel-gfx