[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for VRR/Adaptive Sync Enabling on DP/eDP for TGL+

Patchwork patchwork at emeril.freedesktop.org
Wed Jan 13 22:34:42 UTC 2021

== Series Details ==

Series: VRR/Adaptive Sync Enabling on DP/eDP for TGL+
URL   : https://patchwork.freedesktop.org/series/85831/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
9d81944ab3b3 drm/i915/display/vrr: Create VRR file and add VRR capability check
-:36: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
new file mode 100644

-:41: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/i915/display/intel_vrr.c', please use '//' instead
#41: FILE: drivers/gpu/drm/i915/display/intel_vrr.c:1:
+/* SPDX-License-Identifier: MIT */

-:41: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#41: FILE: drivers/gpu/drm/i915/display/intel_vrr.c:1:
+/* SPDX-License-Identifier: MIT */

-:82: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#82: FILE: drivers/gpu/drm/i915/display/intel_vrr.h:4:
+ * Copyright © 2019 Intel Corporation

total: 0 errors, 4 warnings, 0 checks, 62 lines checked
be5b431abcca drm/i915/display/dp: Attach and set drm connector VRR property
e42f3141b758 drm/i915: Store framestart_delay in dev_priv
7caaca7f5a5d drm/i915: Extract intel_mode_vblank_start()
762167321220 drm/i915: Extract intel_crtc_scanlines_since_frame_timestamp()
a07503674c3c drm/i915/display/dp: Compute VRR state in atomic_check
6bea0561c8ab drm/i915/display/dp: Do not enable PSR if VRR is enabled
0061e69b29f3 drm/i915/display: VRR + DRRS cannot be enabled together
-:22: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 0 warnings, 0 checks, 9 lines checked
5729930e732b drm/i915: Rename VRR_CTL reg fields
1e53166817ac drm/i915/display/vrr: Configure and enable VRR in modeset enable
31bb5d8efd39 drm/i915/display/vrr: Send VRR push to flip the frame
259a9c3dcc00 drm/i915/display/vrr: Disable VRR in modeset disable path
510a51a72bed drm/i915/display/vrr: Set IGNORE_MSA_PAR state in DP Sink
b857d16e4dd6 drm/i915/display: Add HW state readout for VRR
-:55: WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#55: FILE: drivers/gpu/drm/i915/display/intel_vrr.c:164:
+		crtc_state->vrr.pipeline_full = REG_FIELD_GET(VRR_CTL_PIPELINE_FULL_MASK, trans_vrr_ctl);

-:57: WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#57: FILE: drivers/gpu/drm/i915/display/intel_vrr.c:166:
+		crtc_state->vrr.flipline = intel_de_read(dev_priv, TRANS_VRR_FLIPLINE(cpu_transcoder)) + 1;

total: 0 errors, 2 warnings, 0 checks, 46 lines checked
6185d7835cbe drm/i915/display: Helpers for VRR vblank min and max start
6a48576a1fa4 drm/i915: Add vrr state dump
96df6e91917c drm/i915: Fix vblank timestamps with VRR
-:11: WARNING:TYPO_SPELLING: 'minumum' may be misspelled - perhaps 'minimum'?
off the scanline counter when it exceeds the minumum vtotal.

-:83: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV)
#83: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:683:
+#define I915_MODE_FLAG_VRR (1<<6)

-:138: ERROR:TRAILING_STATEMENTS: trailing statements should be on next line (or did you mean 'else if'?)
#138: FILE: drivers/gpu/drm/i915/i915_irq.c:909:
+	} if (use_scanline_counter) {

total: 1 errors, 1 warnings, 1 checks, 81 lines checked
ac9c147c77da drm/i915: Fix vblank evasion with vrr

More information about the Intel-gfx mailing list