[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Shuffle DP code around

Patchwork patchwork at emeril.freedesktop.org
Thu Jan 14 22:13:55 UTC 2021


== Series Details ==

Series: drm/i915: Shuffle DP code around
URL   : https://patchwork.freedesktop.org/series/85878/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4c22a0db410f drm/i915: Fix the training pattern debug print
e5f62898fdee drm/i915: Remove dead TPS3->TPS2 fallback code
77a30579d793 drm/i915: Remove dead signal level debugs
2d486f60d7dd drm/i915: Relocate intel_dp_program_link_training_pattern()
88f2b4fea349 drm/i915: Split intel_ddi_encoder_reset() from intel_dp_encoder_reset()
90067b76465c drm/i915: Fix the PHY compliance test vs. hotplug mishap
303d614cbb64 drm/i915: Introduce g4x_dp.c
-:29: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#29: 
new file mode 100644

-:225: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#225: FILE: drivers/gpu/drm/i915/display/g4x_dp.c:192:
+}
+#define assert_dp_port_disabled(d) assert_dp_port((d), false)

-:235: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#235: FILE: drivers/gpu/drm/i915/display/g4x_dp.c:202:
+}
+#define assert_edp_pll_enabled(d) assert_edp_pll((d), true)

-:260: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#260: FILE: drivers/gpu/drm/i915/display/g4x_dp.c:227:
+	udelay(500);

-:275: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#275: FILE: drivers/gpu/drm/i915/display/g4x_dp.c:242:
+	udelay(200);

-:294: CHECK:USLEEP_RANGE: usleep_range is preferred over udelay; see Documentation/timers/timers-howto.rst
#294: FILE: drivers/gpu/drm/i915/display/g4x_dp.c:261:
+	udelay(200);

-:538: WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#538: FILE: drivers/gpu/drm/i915/display/g4x_dp.c:505:
+	 * ensure that we have vdd while we switch off the panel. */

-:2899: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#2899: FILE: drivers/gpu/drm/i915/display/intel_dp.c:2961:
+								   DP_DS_HDMI_BT2020_RGB_YCBCR_CONV);

-:2931: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2931: FILE: drivers/gpu/drm/i915/display/intel_dp.c:2983:
+		drm_dbg_kms(&i915->drm,
+			   "Failed to set protocol converter RGB->YCbCr conversion mode to %s\n",

total: 0 errors, 3 warnings, 6 checks, 3261 lines checked




More information about the Intel-gfx mailing list