[Intel-gfx] [PATCH] drm/i915/display: Bitwise or the conversion colour specifier together

Chris Wilson chris at chris-wilson.co.uk
Fri Jan 15 08:22:12 UTC 2021

Quoting Nautiyal, Ankit K (2021-01-15 07:24:36)
> On 1/13/2021 5:22 PM, Jani Nikula wrote:
> > On Fri, 08 Jan 2021, Jani Nikula <jani.nikula at intel.com> wrote:
> >> On Thu, 24 Dec 2020, "Nautiyal, Ankit K" <ankit.k.nautiyal at intel.com> wrote:
> >>> Thanks Chris to catch this.
> >>>
> >>> This definitely should be bitwise Operator, as mentioned by Jani is
> >>> right thing to do.
> >>>
> >>> The PCON which I had access to, had the F/W which was using 303Ch
> >>> (previously proposed) for color conversion capability, instead of what
> >>> is latest mentioned in the spec ie. 83h.
> >>>
> >>> While testing, I had to skip this line of code, and hardcoded to older
> >>> register ie. 303Ch.
> >>>
> >>> I Will get this patch tested and update.
> >> In the mean time, the topic/dp-hdmi-2.1-pcon branch has been merged to
> >> drm-next and backmerged to drm-intel-next. So drm-intel-next is where
> >> the fixes should now land.
> > Ankit, where are we with this? I'm anxious to merge this.
> Jani, I checked the lastest F/W we had got for source control mode, but 
> its still having support in older DPCD 303Ch and has not updated to use 
> DPCD 83h.
> So this patch cannot be directly tested.
> Since this patch is correctly fixing to use bitwise operator, can we go 
> ahead with the merge?

Pushed. One hopes we can find a way to gain coverage for wacky DPCD,
this sounds like the sort of thing we need an emulator such as chamelium

More information about the Intel-gfx mailing list