[Intel-gfx] [PATCH 1/2] drm/i915/gt: Do not suspend bonded requests if one hangs

Mika Kuoppala mika.kuoppala at linux.intel.com
Thu Jan 21 11:32:26 UTC 2021


Chris Wilson <chris at chris-wilson.co.uk> writes:

> Treat the dependency between bonded requests as weak and leave the
> remainder of the pair on the GPU if one hangs.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Mika Kuoppala <mika.kuoppala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> index 740ff05fd692..524c8b54d220 100644
> --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
> @@ -1990,6 +1990,9 @@ static void __execlists_hold(struct i915_request *rq)
>  			struct i915_request *w =
>  				container_of(p->waiter, typeof(*w), sched);
>  
> +			if (p->flags & I915_DEPENDENCY_WEAK)
> +				continue;
> +
>  			/* Leave semaphores spinning on the other engines */
>  			if (w->engine != rq->engine)
>  				continue;
> @@ -2088,6 +2091,9 @@ static void __execlists_unhold(struct i915_request *rq)
>  			struct i915_request *w =
>  				container_of(p->waiter, typeof(*w), sched);
>  
> +			if (p->flags & I915_DEPENDENCY_WEAK)
> +				continue;
> +
>  			/* Propagate any change in error status */
>  			if (rq->fence.error)
>  				i915_request_set_error_once(w, rq->fence.error);
> -- 
> 2.20.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list