[Intel-gfx] [PATCH 03/10] drm/i915: Strip out internal priorities

Chris Wilson chris at chris-wilson.co.uk
Thu Jan 21 15:30:47 UTC 2021


Quoting Andi Shyti (2021-01-21 15:23:51)
> Hi Chris,
> 
> > -static void __bump_priority(struct i915_sched_node *node, unsigned int bump)
> > -{
> > -     struct i915_sched_attr attr = node->attr;
> > -
> > -     if (attr.priority & bump)
> > -             return;
> > -
> > -     attr.priority |= bump;
> > -     __i915_schedule(node, &attr);
> > -}
> > -
> > -void i915_schedule_bump_priority(struct i915_request *rq, unsigned int bump)
> > -{
> > -     unsigned long flags;
> > -
> > -     GEM_BUG_ON(bump & ~I915_PRIORITY_MASK);
> > -     if (READ_ONCE(rq->sched.attr.priority) & bump)
> > -             return;
> > -
> > -     spin_lock_irqsave(&schedule_lock, flags);
> > -     __bump_priority(&rq->sched, bump);
> > -     spin_unlock_irqrestore(&schedule_lock, flags);
> > -}
> 
> was, indeed, this function used anywhere else?

Completely overlooked that we had removed the last user a while back.
In my excuse, these have been sitting around for sometime since removing
the no-semaphore boosting.
-Chris


More information about the Intel-gfx mailing list