[Intel-gfx] [PATCH] drm/i915: Restrict DRM_I915_DEBUG to developer builds

[Jani Nikula]

On Fri, 22 Jan 2021, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> Let's not encourage everybody to build i915's debug code, and certainly
> not the build robots who need to scrutinise the production build. Since
> CI will complain if the debug build is broken, having the other build
> bots focus on the builds we don't cover ourselves should improve the
> build coverage.

I don't disagree with this, although I wrote in another mail that I'm
not sure DRM_I915_DEBUG should select DRM_I915_WERROR. I think they
should be two separate things.

Even so, for this change,

Acked-by: Jani Nikula <jani.nikula at intel.com>

>
> Reported-by: Stephen Rothwell <sfr at canb.auug.org.au>
> Fixes: 4f86975f539d ("drm/i915: Add DEBUG_GEM to the recommended CI config")
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> ---
>  drivers/gpu/drm/i915/Kconfig.debug | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug
> index e2d33f1abb3d..5b457fb2d268 100644
> --- a/drivers/gpu/drm/i915/Kconfig.debug
> +++ b/drivers/gpu/drm/i915/Kconfig.debug
> @@ -19,6 +19,8 @@ config DRM_I915_WERROR
>  config DRM_I915_DEBUG
>  	bool "Enable additional driver debugging"
>  	depends on DRM_I915
> +	depends on EXPERT # only for developers
> +	depends on !COMPILE_TEST # never built by robots
>  	select PCI_MSI # ... for iommu enabled by default
>  	select IOMMU_API
>  	select IOMMU_IOVA

-- 
Jani Nikula, Intel Open Source Graphics Center