[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove obj->mm.lock! (rev14)

Thu Jan 28 17:50:09 UTC 2021

== Series Details ==

Series: drm/i915: Remove obj->mm.lock! (rev14)
URL   : https://patchwork.freedesktop.org/series/82337/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
f0caa76735a7 drm/i915: Do not share hwsp across contexts any more, v7.
-:562: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#562: FILE: drivers/gpu/drm/i915/gt/intel_timeline.c:286:
+	if (TIMELINE_SEQNO_BYTES <= BIT(5) && (next_ofs & BIT(5)))

total: 0 errors, 1 warnings, 0 checks, 954 lines checked
2e13b870eff3 drm/i915: Pin timeline map after first timeline pin, v3.
-:16: WARNING:TYPO_SPELLING: 'arithmatic' may be misspelled - perhaps 'arithmetic'?
#16: 
- Fix NULL + XX arithmatic, use casts. (kbuild)
                ^^^^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 296 lines checked
cfa8d0589b53 drm/i915: Move cmd parser pinning to execbuffer
8b3ce40a27dc drm/i915: Add missing -EDEADLK handling to execbuf pinning, v2.
-:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#59: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:452:
+		err = i915_vma_pin_ww(vma, &eb->ww,
 					     entry->pad_to_size,

total: 0 errors, 0 warnings, 1 checks, 75 lines checked
e74b81617eb0 drm/i915: Ensure we hold the object mutex in pin correctly.
13b9209c078e drm/i915: Add gem object locking to madvise.
e4fe993ac962 drm/i915: Move HAS_STRUCT_PAGE to obj->flags
-:110: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#110: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:63:
+			  struct lock_class_key *key, unsigned flags)

-:133: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#133: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:53:
+			  unsigned alloc_flags);

total: 0 errors, 2 warnings, 0 checks, 350 lines checked
0f0d96bdbcb2 drm/i915: Rework struct phys attachment handling
ba20fbbe4737 drm/i915: Convert i915_gem_object_attach_phys() to ww locking, v2.
372b944d10b8 drm/i915: make lockdep slightly happier about execbuf.
0cbd23b2d726 drm/i915: Disable userptr pread/pwrite support.
c973c01f3065 drm/i915: No longer allow exporting userptr through dma-buf
e06a0adf3a6f drm/i915: Reject more ioctls for userptr
229733dcc336 drm/i915: Reject UNSYNCHRONIZED for userptr, v2.
4acda00724a9 drm/i915: Make compilation of userptr code depend on MMU_NOTIFIER.
a653a892ff43 drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v6.
-:294: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#294: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:605:
+static inline int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:295: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#295: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:606:
+static inline int i915_gem_object_userptr_submit_done(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:296: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#296: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:607:
+static inline void i915_gem_object_userptr_submit_fini(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); }

-:354: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#354: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2:
  * SPDX-License-Identifier: MIT

-:358: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#358: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:6:
+ *
+  * Based on amdgpu_mn, which bears the following notice:

-:359: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#359: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:7:
+  * Based on amdgpu_mn, which bears the following notice:
+ *

-:444: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#444: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:63:
+	struct drm_i915_gem_object *obj = container_of(mni, struct drm_i915_gem_object, userptr.notifier);

-:1132: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1132: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:300:
+	pinned = ret = 0;

-:1147: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1147: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:315:
+	if (mmu_interval_read_retry(&obj->userptr.notifier,
+		!obj->userptr.page_ref ? notifier_seq :

-:1268: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#1268: FILE: drivers/gpu/drm/i915/i915_drv.h:601:
+	spinlock_t notifier_lock;

total: 0 errors, 7 warnings, 3 checks, 1208 lines checked
1d108228e705 drm/i915: Flatten obj->mm.lock
6fb47c6d71c7 drm/i915: Populate logical context during first pin.
01ca4854c93e drm/i915: Make ring submission compatible with obj->mm.lock removal, v2.
3abcb0076a68 drm/i915: Handle ww locking in init_status_page
b7166f878991 drm/i915: Rework clflush to work correctly without obj->mm.lock.
22fd424d670c drm/i915: Pass ww ctx to intel_pin_to_display_plane
0b72262b7ad1 drm/i915: Add object locking to vm_fault_cpu
f4419802939b drm/i915: Move pinning to inside engine_wa_list_verify()
-:72: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#72: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:2207:
+	err = i915_vma_pin_ww(vma, &ww, 0, 0,
+			   i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER);

total: 0 errors, 0 warnings, 1 checks, 118 lines checked
42dff2ca5598 drm/i915: Take reservation lock around i915_vma_pin.
980529fa17fc drm/i915: Make lrc_init_wa_ctx compatible with ww locking, v2.
78bd91c8070b drm/i915: Make __engine_unpark() compatible with ww locking.
-:10: WARNING:REPEATED_WORD: Possible repeated word: 'many'
#10: 
many many places where rpm is used, I chose the safest option

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
3b81df55bcf2 drm/i915: Take obj lock around set_domain ioctl
95795e4bbb7e drm/i915: Defer pin calls in buffer pool until first use by caller.
62f9dacbb071 drm/i915: Fix pread/pwrite to work with new locking rules.
-:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 359 lines checked
e9d297ba04ae drm/i915: Fix workarounds selftest, part 1
35b658f67d68 drm/i915: Prepare for obj->mm.lock removal, v2.
-:135: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Thomas Hellström" <thomas.hellstrom at intel.com>' != 'Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>'

total: 0 errors, 1 warnings, 0 checks, 96 lines checked
bf7108bf8725 drm/i915: Add igt_spinner_pin() to allow for ww locking around spinner.
9aff11278b83 drm/i915: Add ww locking around vm_access()
62459a8f2cba drm/i915: Increase ww locking for perf.
c2163fd77906 drm/i915: Lock ww in ucode objects correctly
4199fe13c42d drm/i915: Add ww locking to dma-buf ops.
cc1ce63c2ad4 drm/i915: Add missing ww lock in intel_dsb_prepare.
cb7cd7698571 drm/i915: Fix ww locking in shmem_create_from_object
f266c8a9473f drm/i915: Use a single page table lock for each gtt.
-:112: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#112: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:85:
+		return i915_gem_object_lock(vm->scratch[0], ww);
+	} else {

total: 0 errors, 1 warnings, 0 checks, 154 lines checked
7bc938897064 drm/i915/selftests: Prepare huge_pages testcases for obj->mm.lock removal.
1eb93d4af2a7 drm/i915/selftests: Prepare client blit for obj->mm.lock removal.
38c9614dd45f drm/i915/selftests: Prepare coherency tests for obj->mm.lock removal.
f31a3e48d470 drm/i915/selftests: Prepare context tests for obj->mm.lock removal.
3a539bdf2dfd drm/i915/selftests: Prepare dma-buf tests for obj->mm.lock removal.
74a44c1f5ffe drm/i915/selftests: Prepare execbuf tests for obj->mm.lock removal.
6e441016c863 drm/i915/selftests: Prepare mman testcases for obj->mm.lock removal.
b250bbb9edab drm/i915/selftests: Prepare object tests for obj->mm.lock removal.
39eb2256f43f drm/i915/selftests: Prepare object blit tests for obj->mm.lock removal.
8ed31699898a drm/i915/selftests: Prepare igt_gem_utils for obj->mm.lock removal
4154db61a3c9 drm/i915/selftests: Prepare context selftest for obj->mm.lock removal
5f70e9fc7fdc drm/i915/selftests: Prepare hangcheck for obj->mm.lock removal
7993a281f247 drm/i915/selftests: Prepare execlists and lrc selftests for obj->mm.lock removal
-:163: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#163: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1224:
+	lrc = i915_gem_object_pin_map_unlocked(ce->state->obj,
 				      i915_coherent_map_type(engine->i915));

total: 0 errors, 0 warnings, 1 checks, 130 lines checked
5aecbdc13ffe drm/i915/selftests: Prepare mocs tests for obj->mm.lock removal
141ae6ad925c drm/i915/selftests: Prepare ring submission for obj->mm.lock removal
36f6b0b7722c drm/i915/selftests: Prepare timeline tests for obj->mm.lock removal
89771ac8616d drm/i915/selftests: Prepare i915_request tests for obj->mm.lock removal
4309bd623b24 drm/i915/selftests: Prepare memory region tests for obj->mm.lock removal
503ade404ea1 drm/i915/selftests: Prepare cs engine tests for obj->mm.lock removal
4800c2a64500 drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal
961e9c18fb48 drm/i915: Finally remove obj->mm.lock.
9c9874f35cba drm/i915: Keep userpointer bindings if seqcount is unchanged, v2.
662734223c5f drm/i915: Move gt_revoke() slightly