[Intel-gfx] [PATCH 47/47] drm/i915/guc: Unblock GuC submission on Gen11+

[Martin Peres]

On 01/07/2021 21:24, Martin Peres wrote:
[...]
>>
>>>
>>>> +        i915->params.enable_guc = ENABLE_GUC_LOAD_HUC;
>>>> +        return;
>>>> +    }
>>>> +
>>>> +    /* Default: enable HuC authentication and GuC submission */
>>>> +    i915->params.enable_guc = ENABLE_GUC_LOAD_HUC | 
>>>> ENABLE_GUC_SUBMISSION;
>>>
>>> This seems to be in contradiction with the GuC submission plan which 
>>> states:
>>>
>>> "Not enabled by default on any current platforms but can be enabled via
>>> modparam enable_guc".
>>>
>>
>> I don't believe any current platform gets this point where GuC
>> submission would be enabled by default. The first would be ADL-P which
>> isn't out yet.
> 
> Isn't that exactly what the line above does?

In case you missed this crucial part of the review. Please answer the 
above question.

Cheers,
Martin