[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable

Patchwork patchwork at emeril.freedesktop.org
Mon Jul 5 06:27:15 UTC 2021


== Series Details ==

Series: drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
URL   : https://patchwork.freedesktop.org/series/92188/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
0391ab67ea4c drm/i915/display/dsc: Add Per connector debugfs node for DSC BPP enable
-:53: ERROR:SPACING: space required before the open parenthesis '('
#53: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2409:
+	if(connector->status != connector_status_connected || !crtc)

-:65: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#65: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2421:
+static ssize_t i915_dsc_bpp_support_write(struct file *file,
+						const char __user *ubuf,

-:90: ERROR:SPACING: space required before the open parenthesis '('
#90: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2446:
+	if(connector->status != connector_status_connected || !crtc)

-:114: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#114: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2470:
+static int i915_dsc_bpp_support_open(struct inode *inode,
+					   struct file *file)

-:143: WARNING:SYMBOLIC_PERMS: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'.
#143: FILE: drivers/gpu/drm/i915/display/intel_display_debugfs.c:2529:
+		debugfs_create_file("i915_dsc_bpp_support", S_IRUGO,

total: 2 errors, 1 warnings, 2 checks, 123 lines checked
7f23639025dd drm/i915/display/dsc: Set BPP in the kernel
-:26: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#26: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1246:
+			drm_dbg_kms(&dev_priv->drm,
+				"DSC BPP forced to %d", intel_dp->force_dsc_bpp);

-:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#31: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1251:
+				min_t(u16, drm_edp_dsc_sink_output_bpp(intel_dp->dsc_dpcd) >> 4,
+				pipe_config->pipe_bpp);

-:47: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#47: FILE: drivers/gpu/drm/i915/display/intel_dp.c:1284:
+			pipe_config->dsc.compressed_bpp = min_t(u16,
 							       dsc_max_output_bpp >> 4,

total: 0 errors, 0 warnings, 3 checks, 43 lines checked




More information about the Intel-gfx mailing list