[Intel-gfx] [PATCH v2] drm/i915: Fix wm params for ccs

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Wed Jul 14 19:39:34 UTC 2021


skl_compute_wm_params() didn't take into account ccs modifiers
on graphics ver >= 12

v2 (Imre): Don't set rc_surface flag for mc ccs.

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>
---
 drivers/gpu/drm/i915/intel_pm.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 0cbb79452fcf..5a63920c3913 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -5249,11 +5249,10 @@ skl_compute_wm_params(const struct intel_crtc_state *crtc_state,
 
 	wp->y_tiled = modifier == I915_FORMAT_MOD_Y_TILED ||
 		      modifier == I915_FORMAT_MOD_Yf_TILED ||
-		      modifier == I915_FORMAT_MOD_Y_TILED_CCS ||
-		      modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
+		      is_ccs_modifier(modifier);
 	wp->x_tiled = modifier == I915_FORMAT_MOD_X_TILED;
-	wp->rc_surface = modifier == I915_FORMAT_MOD_Y_TILED_CCS ||
-			 modifier == I915_FORMAT_MOD_Yf_TILED_CCS;
+	wp->rc_surface = is_ccs_modifier(modifier) &&
+			 modifier != I915_FORMAT_MOD_Y_TILED_GEN12_MC_CCS;
 	wp->is_planar = intel_format_info_is_yuv_semiplanar(format, modifier);
 
 	wp->width = width;
-- 
2.28.0



More information about the Intel-gfx mailing list