[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp

Patchwork patchwork at emeril.freedesktop.org
Thu Jul 29 11:48:35 UTC 2021


== Series Details ==

Series: series starting with [1/2] drm/i915/selftests: fixup igt_shrink_thp
URL   : https://patchwork.freedesktop.org/series/93176/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
2870e3292b14 drm/i915/selftests: fixup igt_shrink_thp
2b2db1afa93b drm/i915: Use Transparent Hugepages when IOMMU is enabled
-:6: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")'
#6: 
Usage of Transparent Hugepages was disabled in 9987da4b5dcf

-:25: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit b901bb89324a ("drm/i915/gemfs: enable THP")'
#25: 
References: b901bb89324a ("drm/i915/gemfs: enable THP")

-:26: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#26: 
References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")

-:26: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")'
#26: 
References: 9987da4b5dcf ("drm/i915: Disable THP until we have a GPU read BW W/A")

-:130: WARNING:STATIC_CONST_CHAR_ARRAY: static char array declaration should probably be static const char
#130: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:17:
+	static char thp_native[] = "huge=" CONFIG_DRM_I915_THP_NATIVE;

-:131: WARNING:STATIC_CONST_CHAR_ARRAY: static char array declaration should probably be static const char
#131: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:18:
+	static char thp_iommu[] = "huge=" CONFIG_DRM_I915_THP_IOMMU;

-:146: CHECK:LINE_SPACING: Please don't use multiple blank lines
#146: FILE: drivers/gpu/drm/i915/gem/i915_gemfs.c:33:
+
+

total: 3 errors, 3 warnings, 1 checks, 116 lines checked




More information about the Intel-gfx mailing list