[Intel-gfx] [PATCH v2 4/4] drm/i915/display: Drop FIXME about turn off infoframes

[Ville Syrjälä]

On Fri, May 14, 2021 at 04:22:47PM -0700, José Roberto de Souza wrote:
> intel_dp_set_infoframes() call in intel_ddi_post_disable_dp() will
> take care to disable all enabled infoframes.
> 
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 5bc5528f3091..d3bc5a1a936a 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2762,7 +2762,6 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
>  					conn_state);
>  
>  		/* FIXME precompute everything properly */
> -		/* FIXME how do we turn infoframes off again? */

The FIXME was there for LSPCON and shouldn't have been removed.
No one has yet figured out how to do this.

>  		if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink)
>  			dig_port->set_infoframes(encoder, true, crtc_state,
>  						 conn_state);
> -- 
> 2.31.1

-- 
Ville Syrjälä
Intel