[Intel-gfx] [PATCH] drm/i915: Fix parenthesis and dbuf condition

Matt Roper matthew.d.roper at intel.com
Thu Jun 10 18:18:18 UTC 2021


On Thu, Jun 10, 2021 at 10:02:13AM +0300, Stanislav Lisovskiy wrote:
> Removed excessive parenthesis and placed && on
> previous line in DBUF state checker.
> 
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy at intel.com>

Reviewed-by: Matt Roper <matthew.d.roper at intel.com>

Minor nit:  you probably want "parentheses" in the subject and commit
message as the plural form of the word "parenthesis."


> ---
>  drivers/gpu/drm/i915/intel_pm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 97d9cde64e26..ded0fb8ed817 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -8324,8 +8324,8 @@ void intel_dbuf_post_plane_update(struct intel_atomic_state *state)
>  		intel_atomic_get_old_dbuf_state(state);
>  
>  	if (!new_dbuf_state ||
> -	    ((new_dbuf_state->enabled_slices == old_dbuf_state->enabled_slices)
> -	    && (new_dbuf_state->joined_mbus == old_dbuf_state->joined_mbus)))
> +	    (new_dbuf_state->enabled_slices == old_dbuf_state->enabled_slices &&
> +	     new_dbuf_state->joined_mbus == old_dbuf_state->joined_mbus))
>  		return;
>  
>  	WARN_ON(!new_dbuf_state->base.changed);
> -- 
> 2.24.1.485.gad05a3d8e5
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795


More information about the Intel-gfx mailing list