[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/xelpd: Enabling dithering after the CC1

Patchwork patchwork at emeril.freedesktop.org
Fri Jun 11 13:58:07 UTC 2021


== Series Details ==

Series: drm/i915/xelpd: Enabling dithering after the CC1
URL   : https://patchwork.freedesktop.org/series/91383/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5e4918ee506b drm/i915/xelpd: Enabling dithering after the CC1
-:30: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'crtc_state->pipe_bpp == 36'
#30: FILE: drivers/gpu/drm/i915/display/intel_color.c:1593:
+		if (!crtc_state->dither_force_disable &&
+				(crtc_state->pipe_bpp == 36))

-:31: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#31: FILE: drivers/gpu/drm/i915/display/intel_color.c:1594:
+		if (!crtc_state->dither_force_disable &&
+				(crtc_state->pipe_bpp == 36))

-:53: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'crtc_state->pipe_bpp != 36'
#53: FILE: drivers/gpu/drm/i915/display/intel_display.c:5771:
+	if (crtc_state->dither && (crtc_state->pipe_bpp != 36))

-:56: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'crtc_state->pipe_bpp == 36'
#56: FILE: drivers/gpu/drm/i915/display/intel_display.c:5774:
+	if (crtc_state->dither && (crtc_state->pipe_bpp == 36) && (DISPLAY_VER(dev_priv) < 13))

total: 0 errors, 0 warnings, 4 checks, 43 lines checked




More information about the Intel-gfx mailing list