[Intel-gfx] [PATCH] Revert "drm/i915/display: Drop FIXME about turn off infoframes"

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Jun 11 18:19:16 UTC 2021


On Thu, Jun 10, 2021 at 12:45:27PM -0700, José Roberto de Souza wrote:
> Looks this FIXME is still valid as we need a way to tell LSPCON to
> stop sending infoframes, so reverting it.
> 
> This reverts commit 3f409e4cd579b287a6c41d017e62c392f7997193.
> 
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index 390869bd6b633..0b7fef527e202 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -2810,6 +2810,7 @@ static void intel_ddi_pre_enable(struct intel_atomic_state *state,
>  					conn_state);
>  
>  		/* FIXME precompute everything properly */
> +		/* FIXME how do we turn infoframes off again? */
>  		if (dig_port->lspcon.active && dig_port->dp.has_hdmi_sink)
>  			dig_port->set_infoframes(encoder,
>  						 crtc_state->has_infoframe,
> -- 
> 2.32.0

-- 
Ville Syrjälä
Intel


More information about the Intel-gfx mailing list